Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty URL for conversation link #3895

Merged
merged 2 commits into from
May 8, 2024
Merged

Pretty URL for conversation link #3895

merged 2 commits into from
May 8, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented May 6, 2024 •
edited by mahibi
Loading

Resolves #3828

If the capability mod-rewrite-working is available, it is possible to generate a pretty URL otherwise we need to add index.php in the URL.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch requested a review from mahibi May 6, 2024 14:27
@sowjanyakch sowjanyakch self-assigned this May 6, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label May 6, 2024
@sowjanyakch sowjanyakch added this to the 19.0.1 milestone May 6, 2024
sowjanyakch and others added 2 commits May 8, 2024 13:53
@sowjanyakch @mahibi
Pretty URL for conversation link
acd0b92 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi
Analysis: update lint results to reflect reduced error/warning count
2b4536f 
Signed-off-by: github-actions <github-actions@github.com>
@mahibi mahibi force-pushed the pretty_url_for_conversation_link branch from 3ac4d51 to 2b4536f Compare May 8, 2024 11:54
@mahibi mahibi modified the milestones: 19.0.1, 19.1.0 May 8, 2024
@mahibi mahibi enabled auto-merge May 8, 2024 11:55
@mahibi mahibi merged commit 1150143 into master May 8, 2024
18 checks passed
@mahibi mahibi deleted the pretty_url_for_conversation_link branch May 8, 2024 12:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

Codacy

Lint

TypemasterPR
Warnings8181
Errors119119

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code8484
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total114114

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3895-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
19.1.0
Development

Successfully merging this pull request may close these issues.

Pretty URL for conversation link
2 participants
@sowjanyakch @mahibi