Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set background color for password dialog #4180

Merged
merged 1 commit into from
Sep 11, 2024
Merged

set background color for password dialog #4180

merged 1 commit into from
Sep 11, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 10, 2024

fix #4175

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Sep 10, 2024
@mahibi mahibi added this to the 20.1.0 milestone Sep 10, 2024
@mahibi mahibi self-assigned this Sep 10, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Sep 10, 2024

/backport to stable-20.0

@mahibi @sowjanyakch
set background color for password dialog
5921faa 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@sowjanyakch sowjanyakch force-pushed the bugfix/4175/setBackgroundColorForPasswordDialog branch from e1f9b00 to 5921faa Compare September 11, 2024 08:16
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8692
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4180-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit e7d6dfd into master Sep 11, 2024
16 of 18 checks passed
@sowjanyakch sowjanyakch deleted the bugfix/4175/setBackgroundColorForPasswordDialog branch September 11, 2024 09:08
@backportbot backportbot bot mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

New conversation - "Set Password" dialog has no background color
2 participants
@mahibi @sowjanyakch