Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving search for chat messages #4647

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Improving search for chat messages #4647

wants to merge 8 commits into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 23, 2025 •
edited
Loading

🚧 TODO

  • Got the dialog set up
  • Get API working
  • Adapter?
  • Improving Links
  • System Messages
  • getting the conversation name
  • Optimization.
  • mentions
  • Shimmer
  • make the highlight animation play only once
  • Occasionally stuck on shimmer, seems to be a network issue, with some kind of infinite loop going on with OKHttp. Perhaps I just need some error management, in case I'm not able to retrieve the messages.
  • refactor the MutableState logic
  • Image and Caption formatting the height as needed
  • Mention formatting, check android view
  • Closer analysis shows that I'm using state wrong, causing infinite loops throughout my code. Need to fix this.
  • Use string resources

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Jan 23, 2025
@rapterjet2004 rapterjet2004 self-assigned this Jan 23, 2025
@rapterjet2004 rapterjet2004 force-pushed the issue-4433-improve-search-for-chat-messages branch from bc5d207 to 4c00ddc Compare March 7, 2025 18:29
@rapterjet2004 rapterjet2004 marked this pull request as ready for review March 7, 2025 18:48
@rapterjet2004 rapterjet2004 force-pushed the issue-4433-improve-search-for-chat-messages branch from fceab3b to f1de26e Compare March 11, 2025 17:15
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 11, 2025
@mahibi
Copy link
Collaborator

mahibi commented Mar 18, 2025 •
edited by rapterjet2004
Loading

Looking forward to have this :) From a first look:

  • highlight searched message would be nice

  • scroll to message is missing (the searched message is contained but may be not shown on the screen)

  • a bit more messages before and after would be nice (align with iOS)

  • search inside a chat (upper right menu) is missing (and then only search inside this chat)

  • read checkmarks are missing

  • mentions don't work

  • in the list, it may be not possible to get to know the date of the messages by scolling (only when there is a new day shown inside the chat). This is an improvement that could be also done in the main chat window: showing the date as fixed bubble on the top.

  • images are cropped very much

web:

android search:

  • time is sometimes shown vertically (digits are unter each other) or not at all but height of message is too high. See screenshot:

mahibi
mahibi requested changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@rapterjet2004 rapterjet2004 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 26, 2025
@rapterjet2004
Improving search capability
e318b55 
- Updated api with getContextForChatMessages
- Added ContextChatCompose for viewing the context of messages
- Added ComposeChatAdapter, a reimplementation of chat adapter
- Helper functions
- Added new date header
- Added a better Shimmer

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-4433-improve-search-for-chat-messages branch from 856783c to e318b55 Compare March 28, 2025 14:59
@rapterjet2004
update keys
1e158ef 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
added a drop down and menu, need to make it functional tho
76f6c56 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
Improving search capability
631a042 
- Updated api with getContextForChatMessages
- Added ContextChatCompose for viewing the context of messages
- Added ComposeChatAdapter, a reimplementation of chat adapter
- Helper functions

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
Edit on my Mac Mini later
21b74e7
@rapterjet2004
refactoring files and strings
4e89752 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
refactoring files and strings + detekt
5fc2437 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004
detekt anc codacity
7389240 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4647-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Codacy

Lint

TypemasterPR
Warnings9898
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222120
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi requested changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Requested changes must be addressed to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve search for chat messages
2 participants
@rapterjet2004 @mahibi