Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing duplicate messages #4801

Closed
wants to merge 1 commit into from
Closed

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Mar 14, 2025

workaround with duplicate filtering, underlying issue still exists

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 changed the title workaround with duplicate filtering, underlying issue still exists Fixing duplicate messages Mar 14, 2025
@rapterjet2004 rapterjet2004 self-assigned this Mar 14, 2025
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Mar 14, 2025
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4801-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings100100
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only fixes symptoms but not the root cause.

I fixed the root cause in #4812

@mahibi mahibi closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages appear duplicated after taking a picture
2 participants