Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move notification warning setting to bottom of category #4827

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Mar 27, 2025

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
grafik grafik

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added this to the 21.1.0 milestone Mar 27, 2025
@mahibi mahibi self-assigned this Mar 27, 2025
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9897
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222118
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310206

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4827-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi added the 3. to review Waiting for reviews label Mar 27, 2025
@mahibi mahibi enabled auto-merge March 27, 2025 19:29
@mahibi mahibi merged commit f02028b into master Mar 30, 2025
18 checks passed
@mahibi mahibi deleted the moveNotificationWarningSetting branch March 30, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants