Skip to content

feat(app): launch at startup #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat(app): launch at startup #1004

merged 1 commit into from
Dec 27, 2024
+58 −2

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 24, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

image

image

🚧 Tasks

  • Config + UI
  • Windows
    • Enabling
    • Disabling
  • macOS
    • Enabling
    • Disabling

Linux - will be handled in a separated PR

Sorry, something went wrong.

@ShGKme ShGKme added enhancement New feature or request 2. developing labels Dec 24, 2024
@ShGKme ShGKme added this to the 🌠 Next Patch milestone Dec 24, 2024
@ShGKme ShGKme self-assigned this Dec 24, 2024
@ShGKme
feat(app): launch at startup
Loading
Loading status checks…
a6aa87d 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested a review from Antreesy December 27, 2024 12:28
@ShGKme ShGKme marked this pull request as ready for review December 27, 2024 12:28
Antreesy
Antreesy approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work (tested on WIndows).
Although first time it was hanging on loading screen, I'm not sure whether it's --background flag or whether it's related to this PR. Second time was launched correctly

2024-12-27_14h17_03

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 27, 2024

Although first time it was hanging on loading screen, I'm not sure whether it's --background flag or whether it's related to this PR.

--background only minimizes the main window, but not loading screen.

If loading screen is hidden and something goes wrong - a user has no way to close it.

But there is a small improvement in another branch to show loading only after a few seconds, when loading takes a long time.

@ShGKme ShGKme merged commit 1cf2089 into main Dec 27, 2024
11 checks passed
@ShGKme ShGKme deleted the feat/autostart branch December 27, 2024 16:30
This was referenced Jan 20, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

Run at startup
2 participants
@ShGKme @Antreesy