Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Talk init process #1038

Merged
merged 12 commits into from
Jan 20, 2025
Merged

fix: Talk init process #1038

merged 12 commits into from
Jan 20, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 20, 2025 •
edited
Loading

☑️ Resolves

Separated into small commits.

Primary change - <TalkDesktop> app with <TitleBar> and <TalkWrapper>

Instead of importing everything separatelly, when each part must have had nextcloud/* imports async, resstructure everything into a single Vue app, that is created and mounted async:

  • <TalkWrapper> - a component that mounts and inits talk app
  • <TalkDesktop> - an entire Talk Desktop with <TitleBar> and <TalkWrapper>

Additional changes

  • Stop relying on shared Vue reactivity between Talk and Talk Desktop
  • Clean up talk utils
  • Remove some old code
  • Migrate touched code to TS
  • Related init changes

@ShGKme ShGKme added bug Something isn't working 3. to review labels Jan 20, 2025
@ShGKme ShGKme self-assigned this Jan 20, 2025
@ShGKme

This comment has been minimized.

Sign in to view
ShGKme added 11 commits January 20, 2025 19:49
@ShGKme
refactor: remove CSS loading utils
69fcdb7 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): move route hash init to the setupWebPage
6d5127a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): move talk.service.ts to TalkWrapper
354da13 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): do not rely on Talk Router reactivity
0cfbb03 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): cleanup talk hash integration
6eb22be 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(talk): wrapp talk into TalkWrapper comp and init UI async
f46ff13 
This allows to guarantee that nothing it used until setupWebPage is complete

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): make Viewer init sync
31dd660 
There is no need to be async anymore, as entire Talk Desktop init is async

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(notifications): init in a composable during app init
620aa16 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): rename talk.app.js to TalkDesktop.app.ts
b0b4db9 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): migrate talk.main.js to TS
a694c59 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(talk): move Esc hotkey to TalkDesktop root
9a26d7a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 20, 2025

@ShGKme
chore(ci): temporary disable typecheck
8278040 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 20, 2025

Temporary disabled typecheck on CI.

I cannot perform typecheck without checking types in Talk (which have errors), without loosing types from Talk.

@ShGKme ShGKme merged commit 69b1ef1 into main Jan 20, 2025
10 checks passed
@ShGKme ShGKme deleted the fix/init-process branch January 20, 2025 19:20
@ShGKme ShGKme added this to the 🌠 Next Patch milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.

@nextcloud/vue v8.22.0 breaks user detection
2 participants
@ShGKme @Antreesy