Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Rate Limit error: do not make unnecessary the latest new version requests #125

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 5, 2023

☑️ Resolves

🖼️ Screenshots

No visual changes

🚧 Tasks

  • Do not check a new version on development
  • Do not request GitHub if a new version was already found

Fix: #124
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Apr 5, 2023
@ShGKme ShGKme added this to the v0.3.0 milestone Apr 5, 2023
@ShGKme ShGKme requested a review from nickvergessen April 5, 2023 20:39
@ShGKme ShGKme self-assigned this Apr 5, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks good

@ShGKme ShGKme merged commit 9edcb5c into main Apr 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/124/github-api-rate-limit branch April 6, 2023 07:07
@ShGKme ShGKme mentioned this pull request Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants