fix(patchers): fix importing images and sounds using @nextcloud/router
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
No visual changes in the current version
🚧 Tasks
Previously all the files were requested from the server, except sounds - they were imported as a local file from a copy. This is a problem because:
Talk images should also be imported from the local files, not requested
Talk sounds should not be copied to this repo - we can require them from the
spreed
repo during the build. Only thenotifications
app's sounds could be copied.Update
generateFilePath
patch from@nextcloud/router
:'spreed'
app from thespreed
repository'notifications'
app from the local copyspreed
's soundsPatch
imagePath
from@nextcloud/router
to use patchedgenerateFilePath