Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to @nextcloud/vue@8 #396

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Update to @nextcloud/vue@8 #396

merged 6 commits into from
Nov 3, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 2, 2023

🖼️ Screenshots

image

🚧 Tasks

  • Update @nextcloud/vue
  • Update global server styles
  • Adjust some components: add required aria-label to button and use new NcTextArea

ShGKme added 4 commits November 2, 2023 17:37
@ShGKme
chore(deps): update to @nextcloud/vue@8
2404f1f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
refactor(help): migrate to NcTextArea
4ef788c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(talk): add missing aria-labels
a01ac11 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore: update global server styles
1009c98 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review dependencies technical debt Maintenance and refactoring labels Nov 2, 2023
@ShGKme ShGKme self-assigned this Nov 2, 2023
Antreesy
Antreesy approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

DorraJaouad
DorraJaouad approved these changes Nov 2, 2023
View reviewed changes
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@nickvergessen
Copy link
Member

Lint has some issues:

/home/runner/work/talk-desktop/talk-desktop/src/authentication/renderer/AuthenticationApp.vue
Error:   74:22  error  Missing file extension "mjs" for "@nextcloud/vue/dist/Components/NcButton.js"       import/extensions
Error:   75:27  error  Missing file extension "mjs" for "@nextcloud/vue/dist/Components/NcLoadingIcon.js"  import/extensions
Error:   76:25  error  Missing file extension "mjs" for "@nextcloud/vue/dist/Components/NcTextField.js"    import/extensions

Saw them in other apps too. and there are only mjs and cjs files in the dist folder, no more js

@Antreesy
Copy link
Contributor

Antreesy commented Nov 3, 2023

Saw them in other apps too.

Also saw when migrated in spreed repo, but it's gone after rebase
Might have been fixed by
"@nextcloud/eslint-config": "^8.3.0"

ShGKme added 2 commits November 3, 2023 10:02
@ShGKme
chore(deps): update eslint plugins and configs
8baf022 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(lint): lint with updated configs
e303591 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme merged commit 58a5703 into main Nov 3, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the deps/bump-nextcloud-vue-8 branch November 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review dependencies technical debt Maintenance and refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @nickvergessen @Antreesy @DorraJaouad