-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(authentication): system lang separator #458
Conversation
Thanks @Dtrieb for catching the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For inspiration:
https://github.com/nextcloud/server/blob/1bf15da86343b8213a8554fcf3cda78a9000b455/lib/private/L10N/Factory.php#L480-L535
We could also fall back from dialects to base language (e.g. when de_AT
is configured we could use de
)
Not sure you can check that, but can also be done in a follow up
Done |
However, there is a translation issue for informal German... |
Right... So either we tell translators that this is not like the normal desktop client and they should translate both, or we remap de_DE to de on translation sync like in the files client |
On https://help.nextcloud.com/t/list-of-resources-and-their-priority-for-translation/78312#mobile-clients-4 it is said
Discussing this with the translator. |
`@nextcloud/l10n` expect `_` separator while OS may return `-`. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2cf3abf
to
b1f043b
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
b1f043b
to
569972d
Compare
Tested with @Dtrieb |
@nextcloud/l10n
expect_
separator while OS may return-
.🖼️ Screenshots
de-DE
de_DE