Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): system lang separator #458

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix(authentication): system lang separator #458

merged 2 commits into from
Dec 15, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 13, 2023

@nextcloud/l10n expect _ separator while OS may return -.

🖼️ Screenshots

🏚️ Before 🏡 After
de-DE de_DE
image image

@ShGKme ShGKme added bug Something isn't working 3. to review labels Dec 13, 2023
@ShGKme ShGKme self-assigned this Dec 13, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 13, 2023

Thanks @Dtrieb for catching the issue

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For inspiration:
https://github.com/nextcloud/server/blob/1bf15da86343b8213a8554fcf3cda78a9000b455/lib/private/L10N/Factory.php#L480-L535

We could also fall back from dialects to base language (e.g. when de_AT is configured we could use de)

Not sure you can check that, but can also be done in a follow up

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 13, 2023

For inspiration: https://github.com/nextcloud/server/blob/1bf15da86343b8213a8554fcf3cda78a9000b455/lib/private/L10N/Factory.php#L480-L535

We could also fall back from dialects to base language (e.g. when de_AT is configured we could use de)

Not sure you can check that, but can also be done in a follow up

Done

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 13, 2023

However, there is a translation issue for informal German...

https://github.com/nextcloud/talk-desktop/blob/672cb5a34dd43e71b20e5f56e541ceefda830228/l10n/de.json

@nickvergessen
Copy link
Member

Right... So either we tell translators that this is not like the normal desktop client and they should translate both, or we remap de_DE to de on translation sync like in the files client

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 13, 2023

Right... So either we tell translators that this is not like the normal desktop client and they should translate both, or we remap de_DE to de on translation sync like in the files client

On https://help.nextcloud.com/t/list-of-resources-and-their-priority-for-translation/78312#mobile-clients-4 it is said

Follows the language pattern of the web apps, therefore translations should be available for all server supported languages, e.g. de and de_DE

Discussing this with the translator.

`@nextcloud/l10n` expect `_` separator while OS may return `-`.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/l10n-not-found branch from 2cf3abf to b1f043b Compare December 14, 2023 13:49
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/l10n-not-found branch from b1f043b to 569972d Compare December 14, 2023 20:02
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 15, 2023

  • Rebased onto master to include fixed German translations from translators
  • Fixed a small typo: talk -> spreed in app name in translations

Tested with @Dtrieb

@ShGKme ShGKme merged commit e4fb3f0 into main Dec 15, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/l10n-not-found branch December 15, 2023 18:29
@ShGKme ShGKme mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants