Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(talk): support original path for root page #567

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix(talk): support original path for root page #567

merged 1 commit into from
Mar 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 20, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

No visual changes

@ShGKme
fix(talk): support original path for root page
1853f25 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested review from DorraJaouad and Antreesy March 20, 2024 15:52
@ShGKme ShGKme self-assigned this Mar 20, 2024
@ShGKme ShGKme mentioned this pull request Mar 20, 2024
Merged
5 tasks
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 20, 2024

Note: Alternative solution could be to import router and then change the route via router.replace() before starting the app. But I felt it more reliable to set initial route before using any other Talk code to make closer to the Web Client.

@ShGKme ShGKme merged commit 9edce81 into main Mar 20, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/support-talk-router-with-original-path-for-root branch March 20, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy