Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(talk): typo in TalkHash Pinia store init #568

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 20, 2024

Pinia stores should be used in component's setup context or with pinia instance like useStore(pinia).

There was a typo, I passed instance.$pinia instead of instance to the function, so there instance.$pinia.$pinia === undefined was used as Pinia.

It is not required, Pinia has "active global Pinia" and it usually works, but it is not guaranteed, especially if there are many Pinia instances on the page.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme requested review from DorraJaouad and Antreesy March 20, 2024 22:15
@ShGKme ShGKme self-assigned this Mar 20, 2024
@ShGKme ShGKme merged commit da80b68 into main Mar 21, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/talk-hash-typo branch March 21, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants