Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new title bar design #617

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: new title bar design #617

merged 5 commits into from
Apr 18, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 16, 2024 •
edited
Loading

Resolves

🖼️ Screenshots

🏚️ Before - everywhere

image

🏡 After on Windows 🪟

image

🏡 After on Mac 🍎

image

🏡 After on Linux 🐧

image

With viewer

Talk.Desktop.New.Design.Viewer.mp4

Login Window

Before After
image image
image image

Welcome Window on Mac

Before After
image image

@ShGKme ShGKme self-assigned this Apr 16, 2024
@ShGKme ShGKme added enhancement New feature or request 2. developing design labels Apr 16, 2024
@ShGKme ShGKme marked this pull request as ready for review April 16, 2024 17:17
Antreesy
Antreesy approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux and Mac.

Some Mac window headers seem to have incorrect width (not sure if related):
image

Apart from that, working and code-wise good.

@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 17, 2024 •
edited
Loading

Some Mac window headers seem to have incorrect width (not sure if related):

What do you mean? What window?

marcoambrosini
marcoambrosini reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :)
From a design perspective the only thing I would change is adding slightly more padding to the buttons on the left, similar to this window:

Screenshot 2024-04-17 at 14 14 03

@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 17, 2024

From a design perspective the only thing I would change is adding slightly more padding to the buttons on the left, similar to this window:

Do you mean the Mac's traffic light buttons?

@marcoambrosini
Copy link
Member

Yes @ShGKme

@ShGKme ShGKme force-pushed the feat/new-design branch 3 times, most recently from 9815e94 to e4f009e Compare April 18, 2024 14:19
@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 18, 2024 •
edited
Loading

Changes:

  • Made title clickable again to go to the root on Windows and Linux (Also works by ESC everywhere)
  • Moved traffic light button on Mac to make them in line with the SearchBox
  • Removed traffic light buttons on Mac on Welcome screen
  • Same title bar on Login screen

ShGKme added 4 commits April 18, 2024 17:13
@ShGKme
feat(talk): new title bar design
678d9d8 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(viewer): align with new title bar design
52d1ecc 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
perf(talk): optimize title bar loading
cebf4e1 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(welcome): remove traffic light on Mac
124195c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(authentication): add new title bar design
fd1c9b7 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme merged commit 50947a8 into main Apr 18, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/new-design branch April 18, 2024 16:18
@ShGKme ShGKme mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@marcoambrosini marcoambrosini marcoambrosini left review comments

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review design enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplification of the Design: Too many Title Bars?
4 participants
@ShGKme @marcoambrosini @nickvergessen @Antreesy