Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): create a new cache partition on open login web-view #717

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 17, 2024

☑️ Resolves

Step to reproduce:

  1. Start the login process
  2. Log in as User1
    image
  3. Before finishing the process, realize that you actually wanted to log in as User2
    image
  4. Close the login WebView
  5. Open again
    • Expected: You can log in as User2
      image
    • Actual: You are still logged in as User1 and can only grant access to Talk Desktop
      image

Note: non-persist stores partition until app restart, not window reopening.

🚧 Tasks

  • Create a new cache and storage partition on each Login WebView open, so previous cookies + session are not reused

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Jul 17, 2024
@ShGKme ShGKme requested review from nickvergessen and Antreesy July 17, 2024 08:56
@ShGKme ShGKme self-assigned this Jul 17, 2024
@ShGKme ShGKme merged commit c62b134 into main Jul 17, 2024
6 checks passed
@nickvergessen nickvergessen deleted the fix/reset-login-window-on-reopen branch July 17, 2024 11:25
@ShGKme ShGKme mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants