Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add application config aka settings #835

Merged
merged 9 commits into from
Oct 22, 2024
Merged

feat: add application config aka settings #835

merged 9 commits into from
Oct 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 21, 2024

☑️ Resolves

🖼️ Screenshots

image

🚧 Tasks

Separated by commits with 💙

  • Add AppConfig - application level config
    • Stored in a file
    • Not bind to a specific user session
  • Add frontend for Settings, which includes:
  • Frontend API to init the config
  • Store and composables to work with AppConfig
  • Add a Talk Settings Section "Application"
  • Add some simple settings

More settings are ready and will come in a separate PR

ShGKme added 5 commits October 21, 2024 19:43
@ShGKme
chore(ts): add TS support on main process
908cc31 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(lint): do not require jsdoc returns type in TS
ead16f7 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(config): add AppConfig backend
dea0632 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(app): add relaunch window
a285460 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(config): add settings open button to the menu
c7dc948 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 3. to review labels Oct 21, 2024
@ShGKme ShGKme self-assigned this Oct 21, 2024
@ShGKme ShGKme changed the title feat: add app config feat: add application config aka settings Oct 21, 2024
ShGKme added 4 commits October 21, 2024 20:23
@ShGKme
feat(config): add systemTitleBar toggle support
2bc31ed 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(config): add base frontend api
35e377d 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(config): set theme from config
0ca53c5 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
feat(config): add settings UI
a908929 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme mentioned this pull request Oct 21, 2024
Merged
Antreesy
Antreesy approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, code-wise good.
Maybe Select model part is a bit overcomplicated, and we should upstream it instead?

src/app/AppConfig.ts Show resolved Hide resolved
@ShGKme ShGKme marked this pull request as draft October 22, 2024 10:15
@ShGKme ShGKme marked this pull request as ready for review October 22, 2024 13:37
DorraJaouad
DorraJaouad approved these changes Oct 22, 2024
View reviewed changes
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise 👍🏻
Yet, I didn't test because of some setup issues :(.

@ShGKme ShGKme merged commit e3a1523 into main Oct 22, 2024
11 checks passed
@ShGKme ShGKme deleted the feat/settings branch October 22, 2024 21:45
@ShGKme ShGKme mentioned this pull request Oct 24, 2024
Closed
@ShGKme ShGKme mentioned this pull request Nov 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Desktop settings
3 participants
@ShGKme @DorraJaouad @Antreesy