feat: add play sound config #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref nextcloud/spreed#13437 🙈 |
Wrong link? Or how is lobby related? |
|
Check the description |
ShGKme
force-pushed
the
feat/config-play-sound
branch
from
4ac2d12 to
2785507
Compare
Merged
|
Still fighting ESLint. I don't understand the error |
Antreesy
force-pushed
the
feat/config-play-sound
branch
from
2785507 to
11a70a6
Compare
Antreesy
approved these changes
Nov 12, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
feat/config-play-sound
branch
from
11a70a6 to
85535bc
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com>
ShGKme
force-pushed
the
feat/config-play-sound
branch
from
85535bc to
4d15997
Compare
|
Rebased onto main after a long time. No changes. @Antreesy's changes are included. |
The error still exists but doesn't lead to fail eslint check... |
For clarification: that link is not related. This PR is only about call/notifications sound, same as available on the Web. Not about disabling any sounds completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Desktop alternative for the following web settings (but with respect DND option):
For simple testing - check initial state
🖼️ Screenshots