Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: open second instance in edge cases #876

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: open second instance in edge cases #876

merged 2 commits into from
Nov 11, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 11, 2024

☑️ Resolves

  • Fix opening the second instance when the first one is not fully initialized (on welcome or creating a window)
  • Fix opening the second instance when there are no windows in the first one (on macOS where app can run without windows)

image

@ShGKme
fix: store welcome window as main window
839e92d 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix: create window on focus if there is none
00bc9e2 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Nov 11, 2024
@ShGKme ShGKme self-assigned this Nov 11, 2024
@ShGKme ShGKme mentioned this pull request Nov 11, 2024
Merged
nickvergessen
nickvergessen approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

Bildschirmfoto vom 2024-11-11 15-40-26

After

👍

@ShGKme ShGKme merged commit e7d4db9 into main Nov 11, 2024
10 checks passed
@ShGKme ShGKme deleted the fix/instant-second-instance branch November 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @nickvergessen