Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zoom from config is not applied #893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: zoom from config is not applied #893

wants to merge 1 commit into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 13, 2024

☑️ Resolves

  • Zoom sometimes is not applied
  • Electron's issue

How to test

  1. Open talk (in dev mode is easier)
  2. Change zoom to 120% by wheel/shortcut/settings
  3. Open the config file manually
  4. Change zoomFactor to 0.8
  5. Reload the window (type rs to the console with npm run dev running)

Before

The window is small, but the zoom is big and unchanged

After

New zoom is applied correctly

@ShGKme ShGKme added bug Something isn't working 3. to review labels Nov 13, 2024
@ShGKme ShGKme requested a review from Antreesy November 13, 2024 23:33
@ShGKme ShGKme self-assigned this Nov 13, 2024
src/welcome/welcome.window.js Outdated Show resolved Hide resolved
src/welcome/welcome.window.js Outdated Show resolved Hide resolved
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@Antreesy
Copy link
Contributor

Antreesy commented Nov 15, 2024

Titlebar is not adjusted, when:

  • open instance 1, zoom in
  • close instance 1
  • open instance 2, see bug
    if opening the same instance, can not reproduce
    image

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 15, 2024

  • open instance

Instance of the same app or a separate instance with a new name?

@Antreesy
Copy link
Contributor

  • open instance

Instance of the same app or a separate instance with a new name?

copied directory, so app name is the same?

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 15, 2024

copied directory, so app name is the same?

Why did you do that? ༼ つ ◕_◕ ༽つ

But I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants