-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zoom from config is not applied #893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
force-pushed
the
fix/zoom-issues
branch
from
November 15, 2024 00:01
60c9913
to
42ca007
Compare
nickvergessen
approved these changes
Nov 15, 2024
Instance of the same app or a separate instance with a new name? |
copied directory, so app name is the same? |
Why did you do that? ༼ つ ◕_◕ ༽つ But I'll check. |
ShGKme
force-pushed
the
fix/zoom-issues
branch
from
December 3, 2024 09:25
42ca007
to
acf5b77
Compare
Rebased to resolve conflict + fixed the issue |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/zoom-issues
branch
from
December 3, 2024 10:03
acf5b77
to
b5a03ab
Compare
(approved by @Antreesy in DM) |
This was referenced Dec 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
How to test
zoomFactor
to 0.8rs
to the console withnpm run dev
running)Before
The window is small, but the zoom is big and unchanged
After
New zoom is applied correctly