Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(mac): default to universal arch and adjust scripts and docs #896

Merged
merged 5 commits into from
Nov 15, 2024
Merged

build(mac): default to universal arch and adjust scripts and docs #896

merged 5 commits into from
Nov 15, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 15, 2024

🚧 Tasks

See by commits

  • Lint package.json and scripts/prepare-release-packages.mjs
  • Remove build:all and package:all
    • General recommendation is to always build binaries on the same platform
    • It is still possible
  • Default release:package to the current platform
    • Now on each platform you can just npm run release:package instead of npm run release:package -- --linux
  • Default macOS build to universal architecture
    • Installer is 56% bigger (140MB -> 219MB) but no confusion for not advanced users
    • Add separate scripts to build a specific arch if needed, or we change the decision later

All the docs are updated as well

@ShGKme
chore(editorconfig): use spaces for package.json
256f2d1 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore: lint scripts
f4598fa 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build: remove all-platforms scripts
ead363c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build: default release:package to the current platform
8cc6254 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build(mac): default to universal arch, add separated x64 + arm64 scripts
77dd580 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review distribution 📦 Building, packaging, publishing labels Nov 15, 2024
@ShGKme ShGKme self-assigned this Nov 15, 2024
@ShGKme ShGKme force-pushed the build/add-arch-to-scripts branch from adca5b6 to 77dd580 Compare November 15, 2024 13:14
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 15, 2024

Force pushed a small typo fix in the docs

@ShGKme ShGKme merged commit f7af2cd into main Nov 15, 2024
10 checks passed
@ShGKme ShGKme deleted the build/add-arch-to-scripts branch November 15, 2024 14:49
@ShGKme ShGKme mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review distribution 📦 Building, packaging, publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @nickvergessen @Antreesy