Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: package to ZIP only for Linux #904

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 18, 2024

Removing packaging to zip from macOS and Windows. This was a temp solution and

  • For macOS it's definitely unnecessary - .dmg is a sufficient replacement
  • For Windows, I'm not so sure... But until it's directly requested, let's get rid of it

For Linux there is no universal solution that works for everyone, so keeping zip as a universal base.

Note: .zip wasn't a completely "portable" installation — user data was always in the user folder.

@ShGKme ShGKme added 3. to review distribution 📦 Building, packaging, publishing labels Nov 18, 2024
@ShGKme ShGKme self-assigned this Nov 18, 2024
@ShGKme ShGKme mentioned this pull request Nov 19, 2024
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the build/dont-zip-for-all-platforms branch from 426dd0d to 6057051 Compare November 19, 2024 17:56
@ShGKme ShGKme merged commit 0a23124 into main Nov 19, 2024
10 checks passed
@ShGKme ShGKme deleted the build/dont-zip-for-all-platforms branch November 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review distribution 📦 Building, packaging, publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants