Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mac): only keep app running after close when authenticated #911

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(mac): only keep app running after close when authenticated #911

wants to merge 1 commit into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 20, 2024

☑️ Resolves

  • Chained on: fix(mac): show window on activate when minimized to tray #894
  • Changes behavior on window close
  • Old behavior:
    • Classic macOS
    • Closing any window only closes a window
    • To quit App, a user must explicitly quit with a menu or Cmd+Q
  • New behavior:
    • Only the Talk window closing keeps the app running
    • Closing other windows (Login, Welcome) quits the app

Before

activate-before.mov

After

activate-after.mov

@ShGKme ShGKme self-assigned this Nov 20, 2024
@ShGKme ShGKme mentioned this pull request Nov 20, 2024
Merged
@ShGKme
fix(mac): don't keep app running on Welcome/Login window close
9a20a0c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the feat/only-keep-running-the-talk-window-on-mac branch from c71680e to 9a20a0c Compare November 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ShGKme ShGKme

Labels
2. developing os: macOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShGKme