Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show window when app is rendered #915

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 20, 2024

☑️ Resolves

  • ready-to-show only waits for an HTML document with resources to be loaded
  • But then we need to request all async resources and mount a Vue app
  • This is fast. But the loading is visible and feels like a web-page, not a desktop app
  • Solution: show the window when the Vue app is mounted and the browser has rendered it
  • This is slower. But doesn't feel like a web-page

But I cannot get rid of this white frame... Even when the window actually has a non-white background!

🖼️ Screenshots

🏚️ Before 🏡 After
before after

By frame change:

🏚️ Before 🏡 After
image image
image image
image image
image image
image image
image image
image image

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/wait-window-ready branch from 5ac68fd to 53f9f2c Compare November 25, 2024 14:11
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme self-assigned this Nov 25, 2024
@ShGKme ShGKme force-pushed the fix/wait-window-ready branch from 53f9f2c to 2e23ee7 Compare November 25, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant