Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(windows): add Squirrel MSI #922

Merged
merged 2 commits into from
Nov 22, 2024
Merged

build(windows): add Squirrel MSI #922

merged 2 commits into from
Nov 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 22, 2024

☑️ Resolves

  • Adds MSI installer with Deployment Tool for administrative environment (when the app is installed using Group Policies)
  • Note: the installation is still per-user in the %User%/AppData/Local, not C:/Program Files/
  • Alternative to the classic MSI installer

Details: https://github.com/Squirrel/Squirrel.Windows/blob/develop/docs/using/machine-wide-installs.md

@ShGKme
build(windows): add Squirrel MSI
5a13e8f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review distribution 📦 Building, packaging, publishing labels Nov 22, 2024
@ShGKme ShGKme requested a review from nickvergessen November 22, 2024 12:43
@ShGKme ShGKme self-assigned this Nov 22, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 22, 2024

Doesn't work after signing...

@ShGKme ShGKme marked this pull request as draft November 22, 2024 12:44
@ShGKme
build(windows): do not rename files after build
0e9c53d 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme marked this pull request as ready for review November 22, 2024 15:30
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 22, 2024

In case you want to test it yourself:

  1. Uninstall Nextcloud Talk
  2. Remove %AppData%/Local/NextclouTalk folder completely (no data will be lost)
  3. Run the installer
  4. Sign out and Sign in again. Installation happens automatically after login.

Antreesy
Antreesy approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 22, 2024

Also tested by @Antreesy

@ShGKme ShGKme merged commit e287438 into main Nov 22, 2024
11 checks passed
@ShGKme ShGKme deleted the build/add-squirrel-msi branch November 22, 2024 16:02
@ShGKme ShGKme mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review distribution 📦 Building, packaging, publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy