Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help): scroll long report #934

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix(help): scroll long report #934

merged 2 commits into from
Nov 29, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 29, 2024

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Nov 29, 2024
@ShGKme ShGKme self-assigned this Nov 29, 2024
@ShGKme ShGKme enabled auto-merge November 29, 2024 11:50
@nickvergessen
Copy link
Member

did I do something wrong or you, that the code block is not colored for you?
grafik

And then it feels weird to have the same color overlapping

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but disabled auto-merge for my question

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 29, 2024

did I do something wrong or you, that the code block is not colored for you?

A change in @nextcloud/vue.

Fixed with a new commit:
image

@ShGKme ShGKme merged commit 00d895f into main Nov 29, 2024
10 checks passed
@ShGKme ShGKme deleted the fix/help--scroll-long-report branch November 29, 2024 16:01
@ShGKme ShGKme mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants