Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): add meta tag for light/dark color scheme support #974

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 9, 2024

☑️ Resolves

  • Issue with incorrect color scheme inheritance
  • Nextcloud uses system/light/dark themes, but support them via body data-attributes
  • Without specifying <meta name="color-scheme" content="light dark"> browser/Desktop is unaware of supported color schemes at all and defaults to base theme (light)
  • Although server provides this meta tag, Desktop client does not

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review labels Dec 9, 2024
@Antreesy Antreesy added this to the 🌠 Next Patch milestone Dec 9, 2024
@Antreesy Antreesy self-assigned this Dec 9, 2024
@Antreesy Antreesy requested a review from ShGKme December 16, 2024 09:09
@ShGKme ShGKme merged commit 73e6dac into main Dec 16, 2024
10 checks passed
@ShGKme ShGKme deleted the fix/meta-color-scheme-aware branch December 16, 2024 12:05
@ShGKme ShGKme mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants