Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: allow running release:package without npm ci and without uncommitted changes check #996

Merged
merged 3 commits into from
Dec 20, 2024
Merged

build: allow running release:package without npm ci and without uncommitted changes check #996

merged 3 commits into from
Dec 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 19, 2024

  • Add --skip-check option to skip uncommitted changes checking
    • Allows script development without removing the check
  • Run the script via npx zx
    • Allows running release:package without installing all the dependencies
  • Minor texts changes

@ShGKme
build: add --skip-check to release:package
bcd0d1f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore: minor release:package script improvements
d067ee5 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
build: allow running release:package without npm install
1042e1e 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review distribution 📦 Building, packaging, publishing labels Dec 19, 2024
@ShGKme ShGKme requested a review from Antreesy December 19, 2024 18:05
@ShGKme ShGKme self-assigned this Dec 19, 2024
@ShGKme ShGKme added this to the 🌠 Next Patch milestone Dec 19, 2024
@ShGKme ShGKme mentioned this pull request Dec 19, 2024
Merged
nickvergessen
nickvergessen approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yolo

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 20, 2024

Thanks for testing @SystemKeeper

@ShGKme ShGKme merged commit 6fbe4a5 into main Dec 20, 2024
10 checks passed
@ShGKme ShGKme deleted the build/add-script-options branch December 20, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review distribution 📦 Building, packaging, publishing
Projects
None yet
Milestone
🌠 Next Patch
Development

Successfully merging this pull request may close these issues.
4 participants
@ShGKme @nickvergessen @SystemKeeper @Antreesy