-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the design #664
Comments
I also thought about updating the sidebar. Especially I would like to
What I want to keep as it is, is that I want to show input elements only after the user clicks on something he wants to edit. I find all these input fields visually noisy. |
@raimund-schluessler |
I think it looks very nice, but it somehow doesn't match the overall nextcloud style. What do the @nextcloud/designers think? |
I think that it would fit quite good if the shadows and border radius would just use the amount we have by default in our css variables, worth a try with that imo. |
A bit of feedback:
Also @jancborchardt here. |
Thanks for the feedback!
Keep in mind it's a draft I made using a custom CSS stylesheet. As I said, if the general direction is ok, then it will be made as part of a proper PR. |
@timkrief that looks all really nice! :) Only one piece of feedback on that last screenshot: It’s a bit strange that the shadow of parent elements overlaps the first child, since they have the same amount of shadow. In earlier screenshots it didn’t overlap and looked a bit nicer. Also your other designs from earlier look quite nice! :) As the others said it is first good to use the main variables, and then if you like we can see if it makes sense to change the variables.
Sounds great! By the way, we have a Nextcloud Talk instance with a "Design team" and "Tasks team" room – I can invite you there with a guest account? |
Thanks for the feedback. Of course you can! |
Overall I'd say it's really nice and a definite step forward. Something that I find conceptually doesn't make sense to me though, is that there are gaps between a task and it's subtask. These two things are conceptually linked (one is part of the other) and yet there's a gap between them. On the other hand, a sub task and an unrelated shallower level task are conceptually unrelated, but they're shown as linked, with no gap between them. I would suggest switching this, so there is no gap between a task and it's subtask (as they're connected), but a gap between a subtask and a task of a shallower level (as they're unrelated). Here's my imperfect mockup to demonstrate what I mean: |
Oh sorry for the misunderstanding @Bugsbane It's wasn't a gap, it was a shadow, ignore it, as @jancborchardt said it was nicer without it. |
I think this looks really nice. A PR would be great. |
Just passing by and love all the great support and feedback everyone gave here! This looks super awesome! |
Great stuff :)
edit:
|
@ma12-co This is possible already. You can click "Hide subtasks" in the dropdown menu and all subtasks will be hidden: This works for every task, also subtasks. |
I am not sure about the separation. I think this would look weird if you have a lot of tasks without subtasks. I would not introduce that by default and refer to the custom CSS app since it is a small change. |
Oh, I didn't notice it! @raimund-schluessler, don't you think it would be better to show an icon on the left of the checkbox? Like: |
We show an icon on the right side, left of the dropdown menu (see the second image). If we want to show an icon at the left we would need to shift the checkbox which would leave unused space if no icon is shown. I guess we would need a mockup to judge if that would work. |
Not if the gap is small enough imo, like 4 to 8 px. Currently If you have a lot of tasks with sub-tasks it there's very little hierarchy and it all looks like the same slab. P.S. I'm probably abusing the fact that the title of the issue is very generic xD |
no problem with the checkbox shift imo, it's yet another clue that suggests you that there's something different about that particular task :) Edit: that's also where the plus button could go, to quickly add subtasks, like:
Upon clicking
Once you've clicked enter and confirmed the creation of the first sub-task, a second focused input field appears below it
|
To be honest those variable height elements with labels all around do not look very tidy to me. I think my proposal would still look cleaner. |
I would like to keep the checkbox on the very left. In my opinion it is the most important action element. Moving it to the right would be counterintuitive for me. And every other todo app I am aware of also has the checkbox to the very left. Breaking that custom for the add-subtask/show-subtask button is not reasonable for me, since these buttons are not so important. However, I can understand that one would like to show it more prominently when a task has subtasks (which might be even hidden). But I would like to show that on the right side at the position where we already have the respective icon. We could maybe show the number of subtasks as a counter with a colored background (similar to how tasks.org apparently does it, but in a single line). |
Ok, so how about putting the arrow on the far right of the task element? Too many icons on the right? We can move the favorite star to the right of the checkbox, gmail style. |
Yeah I don't like multiple lines at all either. I think they do that because of the size of mobile displays. but I like that the number of subtasks is displayed and that it is shown the same way as a label. As if the fact that it has subtasks put it in a "has subtasks" category 🙂 I really think the checkbox should be the only thing on the right personnally. |
I like the |
I find it weird that it would act differently for tasks with or without subtasks and on top of that for root tasks and deeper tasks. Plus it could create confusion for when tasks from all calendars are displayed as groups in the main view, as it would visually create multiple groups for one calendar. I think the indentation already provides the information we need to clearly comprehend the hierarchy and separations etc. |
I don't think there's any problem if we have a 4px gap even when the tasks are collapsed or for when they don't have subtasks. @timkrief, the indentation might be enough for you as a programmer but screenshot 1 of the previous comment is unquestionably clearer to read for the average user and presents no significant drawbacks. That's why I think we should go for it. |
Just some meta input, since the issue has long veered off its original intention:
|
I agree, for the PRs we should keep it small and start to include only the stuff where we have a consensus. I will try to summarize a bit: Where we have a consensus:
Various opinions:
Since I have likely forgotten some ideas, I think it would be best to open separate issues for them. Also, I will close this issue once the task list and sidebar are updated. @timkrief Could you please create a PR with the adjustments to the task list you proposed? And @jancborchardt please add @timkrief to the Tasks repo. |
Here's an updated style.scss that matches the designs I shown in issue nextcloud#664
Thanks for the summary @raimund-schluessler!
We can always see about this in the future, but it should not block the other enhancements indeed. :)
Yep, a counter as a subline is pretty good, Microsoft To Do does the same:
Added, welcome @timkrief! :) |
Here's an updated style.scss that matches the designs I shown in issue nextcloud#664 Signed-off-by: Tim Krief <tim@timkrief.com>
Here's an updated style.scss that matches the designs I shown in issue #664 Signed-off-by: Tim Krief <tim@timkrief.com>
Please have a look at #1136 for the task list style PR. |
The sidebar looks a litte bit outdated.
Maybe we could do some polish and use elements of the deck or calendar app (each from the vue branch):
Deck:
Calendar:
The text was updated successfully, but these errors were encountered: