Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build environment #105

Merged
merged 4 commits into from
Sep 9, 2017
Merged

Update Build environment #105

merged 4 commits into from
Sep 9, 2017

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Sep 2, 2017

Implements #101

  • Use Yarn instead of NPM
  • Use gulp instead of grunt
    • Minify js files
  • Use Yarn + gulp instead of bower

#94 Should be in first.

@raimund-schluessler
Copy link
Member Author

There is a problem with using Yarn + Gulp instead of bower:

The jquery-timepicker package https://github.com/fgelinas/timepicker which is currently used is not available via NPM since it does not have a package.json in its git repository. Since the last commit there was nearly 4 years ago, I suppose this is not going to change.

For now, I will manually checkin the old timepicker in a vendor_legacy folder, which is not maintained by NPM.

In the long run, we should move to a still maintained timepicker script, maybe directly in server: nextcloud/server#6348

@skjnldsv
Copy link
Member

skjnldsv commented Sep 9, 2017

Build works fine! :)
But why is there so many commits?
Why not add only the required ones? I can't keep up with all of this! :'(

@raimund-schluessler
Copy link
Member Author

But why is there so many commits?
Why not add only the required ones? I can't keep up with all of this! :'(

I am sorry for this. The problem is that they are hard to separate at the moment because they depend on what was done in the previous PRs (which are not merged yet). We should start to merge with #94 and then I can rebase and they will be a lot better to review.

@skjnldsv
Copy link
Member

skjnldsv commented Sep 9, 2017

@raimund-schluessler Is this the next one? :)

@raimund-schluessler
Copy link
Member Author

Yes, I am rebasing at the moment.

@raimund-schluessler
Copy link
Member Author

Ok, it is rebased and the build still works as it should. I will merge this one and go on with rebasing #107.

@raimund-schluessler raimund-schluessler merged commit dabd604 into master Sep 9, 2017
@raimund-schluessler raimund-schluessler deleted the build branch September 9, 2017 16:17
@skjnldsv
Copy link
Member

skjnldsv commented Sep 9, 2017

Total time 2 min 28 sec
Wow that's fast! :D 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants