Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate the app to vue 3 #1971

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore: migrate the app to vue 3 #1971

merged 1 commit into from
Feb 1, 2024

Conversation

raimund-schluessler
Copy link
Member

@raimund-schluessler raimund-schluessler commented Apr 22, 2022

This PR migrates the Tasks app to use vue3.

I would like to merge this issue even though we do not have a final release of nextcloud/vue@9 yet. It has been open for long enough, and we should push towards a final release anyway. In case we do not find any issues, I think it should be ok to merge already.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1971 (8f9bf25) into master (5f6f5b5) will decrease coverage by 24.88%.
Report is 120 commits behind head on master.
The diff coverage is n/a.

❗ Current head 8f9bf25 differs from pull request most recent head 931dfe2. Consider uploading reports for the commit 931dfe2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1971       +/-   ##
==========================================
- Coverage   24.87%       0   -24.88%     
==========================================
  Files          63       0       -63     
  Lines        2388       0     -2388     
  Branches      257       0      -257     
==========================================
- Hits          594       0      -594     
+ Misses       1776       0     -1776     
+ Partials       18       0       -18     

@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 2 times, most recently from a246054 to af441f5 Compare January 25, 2024 21:06
@raimund-schluessler raimund-schluessler changed the title Vue 3 chore: migrate the app to vue 3 Jan 25, 2024
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 4 times, most recently from a52f654 to 931fc5d Compare January 27, 2024 21:16
@raimund-schluessler raimund-schluessler added this to the 0.16.0 milestone Jan 27, 2024
@raimund-schluessler raimund-schluessler marked this pull request as ready for review January 27, 2024 21:29
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@skjnldsv
Copy link
Member

Time for 1.0.0? 😁

image

@raimund-schluessler
Copy link
Member Author

Time for 1.0.0? 😁

image

🙂
My internal planning was to release 1.0.0 once we have #2318.

Copy link

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice work!

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler merged commit 79ce0ac into master Feb 1, 2024
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the vue3 branch February 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants