Limit height of #editor not .content-wrapper

In rich workspaces scrolling still made the menu-bubble render at the wrong place. The element that the absolute position of the menu-bubble is relative to needs to grow with the text so tiptap can position the menu-bubble correctly. Now we also do not need the margin bottom anymore. Signed-off-by: Azul <azul@riseup.net>
nextcloud · Oct 27, 2021 · 0b19101 · 0b19101
1 parent 750fe80
commit 0b19101
Show file tree

Hide file tree

Showing 14 changed files with 20 additions and 22 deletions.
diff --git a/js/editor-rich.js b/js/editor-rich.js
diff --git a/js/editor-rich.js.map b/js/editor-rich.js.map
diff --git a/js/editor.js b/js/editor.js
diff --git a/js/editor.js.map b/js/editor.js.map
diff --git a/js/text-files.js b/js/text-files.js
diff --git a/js/text-files.js.map b/js/text-files.js.map
diff --git a/js/text-public.js b/js/text-public.js
diff --git a/js/text-public.js.map b/js/text-public.js.map
diff --git a/js/text-text.js b/js/text-text.js
diff --git a/js/text-text.js.map b/js/text-text.js.map
diff --git a/js/text-viewer.js b/js/text-viewer.js
diff --git a/js/text-viewer.js.map b/js/text-viewer.js.map
diff --git a/src/components/MenuBubble.vue b/src/components/MenuBubble.vue
@@ -176,7 +176,6 @@ export default {
 		&.is-active {
 			opacity: 1;
 			visibility: visible;
-			margin-bottom: -3px;
 		}
 
 		&__button {

diff --git a/src/views/RichWorkspace.vue b/src/views/RichWorkspace.vue
@@ -213,12 +213,11 @@ export default {
 	}
 
 	#rich-workspace::v-deep #editor {
-		overflow: visible !important;
+		overflow: scroll !important;
+		max-height: calc(40vh - 40px);
 	}
 
 	#rich-workspace::v-deep .content-wrapper {
-		overflow: scroll !important;
-		max-height: calc(40vh - 50px);
 		padding-left: 10px;
 	}