Merge pull request #3288 from nextcloud/fix/1525

TaskItem: Don't allow toggling while editor is readonly
nextcloud · Nov 2, 2022 · ded6b61 · ded6b61
2 parents 308d945 + d5fe1d5
commit ded6b61
Show file tree

Hide file tree

Showing 11 changed files with 17 additions and 16 deletions.
diff --git a/js/editor.js b/js/editor.js
diff --git a/js/editor.js.map b/js/editor.js.map
diff --git a/js/text-files.js b/js/text-files.js
diff --git a/js/text-files.js.map b/js/text-files.js.map
diff --git a/js/text-public.js b/js/text-public.js
diff --git a/js/text-public.js.map b/js/text-public.js.map
diff --git a/js/text-text.js b/js/text-text.js
diff --git a/js/text-text.js.map b/js/text-text.js.map
diff --git a/js/text-viewer.js b/js/text-viewer.js
diff --git a/js/text-viewer.js.map b/js/text-viewer.js.map
diff --git a/src/nodes/TaskItem.js b/src/nodes/TaskItem.js
@@ -117,7 +117,8 @@ const TaskItem = TipTapTaskItem.extend({
 						const isListClicked = event.target.tagName.toLowerCase() === 'li'
 						if (!isListClicked
 							|| !parentList
-							|| parentList.node.type !== schema.nodes.taskItem) {
+							|| parentList.node.type !== schema.nodes.taskItem
+						    || !view.editable) {
 							return
 						}
 						const tr = state.tr