Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read only shared files seem editable in current main branch #2769

Closed
max-nextcloud opened this issue Aug 1, 2022 · 3 comments · Fixed by #2851
Closed

Read only shared files seem editable in current main branch #2769

max-nextcloud opened this issue Aug 1, 2022 · 3 comments · Fixed by #2851
Labels
Milestone

Comments

@max-nextcloud
Copy link
Collaborator

Describe the bug
Files that are shared as read only seem to be editable. When clicking a line it get's a blue highlight and one can type and change its content.

To Reproduce
Steps to reproduce the behavior:

  1. Create a .md file with some paragraphs
  2. Create a read only link to it
  3. open that link in an incognito browser window
  4. Click one of the paragraphs and start typing

Expected behavior
The text remains as it was. No highlights are applied and no content is altered

Screenshots
Bildschirmfoto vom 2022-08-01 10-32-49

Client details:

  • OS: ubuntu 22.04
  • Browser: Chromium
  • Version: current main branch
  • Device: desktop

Text app version: current main branch

This behavior disappears when removing the webkit-user-modify setting:
Bildschirmfoto vom 2022-08-01 10-34-45

@juliushaertl
Copy link
Member

Good catch, seems I applied the rule to widely while it should only be for contenteditable=true https://github.com/nextcloud/text/pull/2712/files#diff-e45ce3a454c97498daa53f43c438ba1be6ee1b3cfea83cee90053fbe14ad78b2R17-R18

@juliushaertl juliushaertl added this to the Nextcloud 25 milestone Aug 1, 2022
juliushaertl pushed a commit that referenced this issue Sep 26, 2022
fixes #2769

Signed-off-by: Max <max@nextcloud.com>
nextcloud-command pushed a commit that referenced this issue Sep 28, 2022
fixes #2769

Signed-off-by: Max <max@nextcloud.com>
@alarmix
Copy link

alarmix commented Oct 29, 2022

I have a problem that may be somehow connected: if I share a folder read-only, the .txt and .md files in that folder can't be viewed. The window is empty, with only the filename shown at the top, and in the console I have the following error:
PUT https://xxxxxxxxx/index.php/apps/text/session/create 401 (Unauthorized)

@juliushaertl
Copy link
Member

Please open a new issue and provide the additional details asked for in the issue template. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants