-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate header and paragraph buttons? #353
Comments
Yeah, I’d say that’s a good point. But then we have to have an |
Whatever you have in the header button seems clear, at least on the question of a drop-down menu. You can probably just move the paragraph icon into the header menu. Even the existing icon for the header menu is probably fine. The paragraph icon is not intuitive shown in isolation, but the juxtaposition to the header options probably expresses the concept with adequate clarity. |
The issue is that the default action icon of the menu also functions as the icon of what is currently active. And since everything is basically normal paragraph by default, it will show the paragraph icon and you might never click it. This is why it needs a caret. |
I see. I definitely support an indication of the drop-down menu whenever there is one. Regarding the issue of icon, perhaps the user would be best guided by continued use of the header icon. The menu has three functions: to make a regular paragraph into a header, to make a header into a paragraph, and to change a header level. All three cases involve a header, so the header icon carries the needed information. |
Another option is to use buttons (and keyboard shortcuts) that promote or demote header level (with a body paragraph having the position of level-zero header), rather than setting the level to a chosen value. Most invocations of commands related to header level will be to promote or demote a header level one position, or to set a paragraph to a header immediately after it is typed. |
I landed here because i was searching the repo to learn if the para button had any function. I think the current icon is really confusing. For me it's a symbol of a line break / para break. Not the unformatted text itself. I'd just drop the Paragraph button completely. You can turn a heading into a para by clicking the name of the heading again. Just like you can turn bold into normal text by clicking bold again. If you just turned something into a heading accidentally undo will also work. |
Sounds good to me 👍 |
fixes #353. The paragraph button was confusing for a number of reasons: * it only acts on headings * the symbol indicates a line break rather than the removal of formatting * there are other ways to turn headings back to normal text * all other formatting is removed by clicking the same button again
fixes #353. The paragraph button was confusing for a number of reasons: * it only acts on headings * the symbol indicates a line break rather than the removal of formatting * there are other ways to turn headings back to normal text * all other formatting is removed by clicking the same button again Signed-off-by: Azul <azul@riseup.net>
fixes #353. The paragraph button was confusing for a number of reasons: * it only acts on headings * the symbol indicates a line break rather than the removal of formatting * there are other ways to turn headings back to normal text * all other formatting is removed by clicking the same button again Signed-off-by: Azul <azul@riseup.net>
I tried the "paragraph" button many times, attempting to discover its function. It never seemed to have any effect. I almost gave up before realizing that paragraph means not header.
Maybe the paragraph and header buttons should be consolidated. Regular body text might just be one of the drop down options, in addition to the header levels.
I never saw this kind of interface before. I think it is probably confusing since there are so many rich text editors that have a different solution.
The text was updated successfully, but these errors were encountered: