-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary editor colors during editing sessions #1296
Conversation
Aaawesome! :) So if we use the same colors as for the avatars, the contrast should work, as @skjnldsv made sure that contrast is enough. :) Even if it's only enough for WCAG A or AA level that is fine though, since it can just be turned off and full text contrast is there. About the indication of the color in the avatar list, you are referring to the issue that when people have avatars, the placeholder color is not visible, right? I'd say a fix here is to give the avatar a 2px border of the author color. That would work both in the list of avatars-only as well as in the menu including the names. |
Alternative for the highlight color as discussed: Reduce opacity of the author color so we can keep the text black, would make it more readable. And then the highlight color looks more like a text marker pen. :) |
ea442d9
to
cf3b941
Compare
…emirror Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
cf3b941
to
ec853ba
Compare
Ready for review and testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good as far as I can judge 👍
First attempt towards implementing #91
For now the author annotation is only available during editing sessions
otherwise we might be able to persist decorations as marks in the document which would be also useful for persisting them later onFollow up
cc @jancborchardt for design feedback :)