Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert images from local device (or link) #1900

Merged
merged 63 commits into from
Jan 3, 2022
Merged

Insert images from local device (or link) #1900

merged 63 commits into from
Jan 3, 2022

Commits on Jan 3, 2022

  1. begin to implement local image insertion, UI almost done 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ba3fc84 View commit details
    Browse the repository at this point in the history

  2. basic upload ok 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ab99206 View commit details
    Browse the repository at this point in the history

  3. improve basic upload 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    bc2e4d3 View commit details
    Browse the repository at this point in the history

  4. create /Text if needed 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    477573d View commit details
    Browse the repository at this point in the history

  5. insert link working 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b7234c0 View commit details
    Browse the repository at this point in the history

  6. loading animation when inserting image link or uploading image 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    48e9828 View commit details
    Browse the repository at this point in the history

  7. show errors 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    361f265 View commit details
    Browse the repository at this point in the history

  8. fix link input reset issue 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    cb463ea View commit details
    Browse the repository at this point in the history

  9. upload image file via Text API call for more flexibility in saved fil… 

    …e location

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    a103b98 View commit details
    Browse the repository at this point in the history

  10. display/upload/add-link works with attachment folder in user context 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7267f0b View commit details
    Browse the repository at this point in the history

  11. identify image by name instead of id in text file content 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    849b4f0 View commit details
    Browse the repository at this point in the history

  12. serve attached images to public links 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    05098ce View commit details
    Browse the repository at this point in the history

  13. public upload/link-insertion almost done, issue with missing fileId i… 

    …n single file share

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    761d0dd View commit details
    Browse the repository at this point in the history

  14. fix upload/link-dl in single file share edition, get it from upload r… 

    …esponse

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f3f03cf View commit details
    Browse the repository at this point in the history

  15. fix share link permissions check 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7fde881 View commit details
    Browse the repository at this point in the history

  16. add user share permissions check 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    6916b96 View commit details
    Browse the repository at this point in the history

  17. cleanup server side stuff 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    1fedc8f View commit details
    Browse the repository at this point in the history

  18. check mime type on upload (client and server side) 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    09552de View commit details
    Browse the repository at this point in the history

  19. provide content-type header when serving images 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b1fe365 View commit details
    Browse the repository at this point in the history

  20. serve image previews 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    1b33096 View commit details
    Browse the repository at this point in the history

  21. hide image link input when closing image action popup 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    c3a8e5d View commit details
    Browse the repository at this point in the history

  22. fix function naming 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    a541ad9 View commit details
    Browse the repository at this point in the history

  23. rename menu items 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    39114e0 View commit details
    Browse the repository at this point in the history

  24. change attachment folder name to .attachments.FILE_ID 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    65c69ff View commit details
    Browse the repository at this point in the history

  25. use attachment folder when inserting image from Files 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    2f6a92b View commit details
    Browse the repository at this point in the history

  26. avoid exposing exception msg to user 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    340f788 View commit details
    Browse the repository at this point in the history

  27. provide preview only if mime type is supported 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    19d014b View commit details
    Browse the repository at this point in the history

  28. add annotation 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    54ff445 View commit details
    Browse the repository at this point in the history

  29. remove useless path attribute in insert/upload response 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    94572f8 View commit details
    Browse the repository at this point in the history

  30. fix image serve endpoints 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f1c25a8 View commit details
    Browse the repository at this point in the history

  31. address review comments 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    4e074e7 View commit details
    Browse the repository at this point in the history

  32. psalm issues 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f3b1559 View commit details
    Browse the repository at this point in the history

  33. php-cs checks 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ed48dcf View commit details
    Browse the repository at this point in the history

  34. store file id (instead of name) in markdown image links, cleanup atta… 

    …chments when needed

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    fc56680 View commit details
    Browse the repository at this point in the history

  35. implement auto attachment management for file deletion/move/copy 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    551729e View commit details
    Browse the repository at this point in the history

  36. fix php7.3 compat 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    cb42dae View commit details
    Browse the repository at this point in the history

  37. add class to image <actions> 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    0762feb View commit details
    Browse the repository at this point in the history

  38. fix moveAttachments in shared context (single file and directory share) 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    a2fcb4d View commit details
    Browse the repository at this point in the history

  39. small fixes 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    3e68770 View commit details
    Browse the repository at this point in the history

  40. attempt to fix file copy 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    6245dd2 View commit details
    Browse the repository at this point in the history

  41. forgot something while solving rebase conflicts 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    014d081 View commit details
    Browse the repository at this point in the history

  42. make image upload endpoints public and use session token to authenticate 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    4f54f4d View commit details
    Browse the repository at this point in the history

  43. use image file name instead of file ID in content links 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    32c0a37 View commit details
    Browse the repository at this point in the history

  44. use Vuex to store current session and get it in the ImageView component 

    rename some variables
use session auth instead of NC auth to serve images

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    81aebee View commit details
    Browse the repository at this point in the history

  45. adjustments after rebase 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ed2f474 View commit details
    Browse the repository at this point in the history

  46. fix stuff after PR comments 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    b4b4f1d View commit details
    Browse the repository at this point in the history

  47. fix other stuff after PR comments 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    3905852 View commit details
    Browse the repository at this point in the history

  48. fix other stuff after PR comments 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    dc710f7 View commit details
    Browse the repository at this point in the history

  49. factorize getAttachmentDirectoryForFile and getOrCreateAttachmentDire… 

    …ctoryForFile

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    9b1c396 View commit details
    Browse the repository at this point in the history

  50. remove Unnecessary else 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    2f23e2d View commit details
    Browse the repository at this point in the history

  51. fix stuff after PR comments 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    cde5784 View commit details
    Browse the repository at this point in the history

  52. stop returning null in getAttachmentDirectoryForFile, use exceptions … 

    …instead

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    29b7e0f View commit details
    Browse the repository at this point in the history

  53. remove unused param in simpleDownload 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d64bb66 View commit details
    Browse the repository at this point in the history

  54. return 403 when session is invalid 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8794427 View commit details
    Browse the repository at this point in the history

  55. add check on uploaded image 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7eaf9d6 View commit details
    Browse the repository at this point in the history

  56. stream uploaded file to the storage with a resource 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ef8358b View commit details
    Browse the repository at this point in the history

  57. safely get image mimetype 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    6ba9da8 View commit details
    Browse the repository at this point in the history

  58. allow image upload/link-insertion with email links and from a Talk room 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    dc92e02 View commit details
    Browse the repository at this point in the history

  59. improve image link generation and getAttachmentNamesFromContent(), im… 

    …plement basic tests

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    e628527 View commit details
    Browse the repository at this point in the history

  60. use specific exception on upload error 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    f65698a View commit details
    Browse the repository at this point in the history

  61. fix some CI errors 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    342952d View commit details
    Browse the repository at this point in the history

  62. add basic tests for ImageView.vue 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
    Julien Veyssier committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    1f9cef4 View commit details
    Browse the repository at this point in the history

  63. fix some psalm false positives 

    Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @nextcloud-command
    Julien Veyssier authored and nextcloud-command committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    dea3a59 View commit details
    Browse the repository at this point in the history