Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @nextcloud/logger for all frontend logging #2866

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Use @nextcloud/logger for all frontend logging #2866

merged 2 commits into from
Sep 13, 2022

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 6, 2022

Summary

The nextcloud logger take account for the configured logging level,
so only messages the user / administrator wants are logged.
This fixes #2846 (no debug messages are logged if not configured).

@susnux
Copy link
Contributor Author

susnux commented Sep 6, 2022

/compile amend

@susnux susnux requested a review from max-nextcloud September 6, 2022 13:24
@susnux susnux requested a review from vinicius73 September 8, 2022 13:50
@susnux
Copy link
Contributor Author

susnux commented Sep 8, 2022

/compile amend

max-nextcloud
max-nextcloud approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. Should not have any impact on behavior other than going through the @nextcloud/logger interface instead of console.*.

@max-nextcloud max-nextcloud force-pushed the feat/logger branch 2 times, most recently from 86638b6 to 48c7ab8 Compare September 13, 2022 10:29
@max-nextcloud
Copy link
Collaborator

/compile

@max-nextcloud
Copy link
Collaborator

/compile

@susnux @max-nextcloud
Use @nextcloud/logger for all logging
81d7af7 
The nextcloud logger take account for the configured logging level,
so only messages the user / administrator wants are logged.
This fixes #2846 (no debug messages are logged if not configured).

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@max-nextcloud
Copy link
Collaborator

/compile

@nextcloud-command
Compile assets
4de84df 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud merged commit 78e1e6e into master Sep 13, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@susnux susnux deleted the feat/logger branch May 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@vinicius73 vinicius73 Awaiting requested review from vinicius73

Assignees
No one assigned
Labels
3. to review javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug console.log statement leftover in code
3 participants
@susnux @max-nextcloud @nextcloud-command