Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ @nextcloud/vue v7 #2907

Merged
merged 2 commits into from
Sep 13, 2022
Merged

⬆️ @nextcloud/vue v7 #2907

merged 2 commits into from
Sep 13, 2022

Conversation

vinicius73
Copy link
Member

No description provided.

@vinicius73 vinicius73 force-pushed the update/nextcloud-vue-7-beta-2 branch from 0fe0ed8 to 15636f4 Compare September 12, 2022 18:16
julien-nc
julien-nc reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good.. Clicked around the interface and no issue found.

Tests are not passing locally though. In share.spec.js:

Timed out retrying after 4000ms: Expected to find element: #viewer[data-handler="text"], but never found it.

image

@vinicius73
Copy link
Member Author

/rebase

@nextcloud-command nextcloud-command force-pushed the update/nextcloud-vue-7-beta-2 branch from 15636f4 to 6a0b72c Compare September 13, 2022 01:00
@max-nextcloud
Copy link
Collaborator

/rebase

@nextcloud-command nextcloud-command force-pushed the update/nextcloud-vue-7-beta-2 branch from 6a0b72c to 1ece76a Compare September 13, 2022 05:46
@max-nextcloud
Copy link
Collaborator

/compile

@max-nextcloud
⬆️ Upgrade dependencies.
cb4f236 
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the update/nextcloud-vue-7-beta-2 branch from 9f7c5fa to cb4f236 Compare September 13, 2022 09:17
@max-nextcloud
Copy link
Collaborator

/compile

@nextcloud-command
Compile assets
a96ec47 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud
Copy link
Collaborator

Tests are not passing locally though. In share.spec.js:

Passed twice for me. I'll approve and we can investigate the failing test later.

max-nextcloud
max-nextcloud approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks heaps for looking into this!

@max-nextcloud max-nextcloud merged commit 2b52793 into master Sep 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the update/nextcloud-vue-7-beta-2 branch September 13, 2022 09:27
This was referenced Sep 13, 2022
Closed
Closed
@Raudius Raudius mentioned this pull request Sep 14, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc left review comments

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review dependencies: javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinicius73 @max-nextcloud @julien-nc @nextcloud-command