Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix: relative link in RichWorkspace #3323

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 27, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #3269

mejo-
mejo- previously approved these changes Oct 27, 2022
@mejo- mejo- self-requested a review October 27, 2022 17:33
@mejo- mejo- dismissed their stale review October 27, 2022 17:33

too fast, apparently there's manual work needed.

@vinicius73
Copy link
Member

/compile

Vinicius Reis added 2 commits November 7, 2022 17:44
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@max-nextcloud
Copy link
Collaborator

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@cypress
Copy link

cypress bot commented Nov 7, 2022



Test summary

94 1 0 0Flakiness 2


Run details

Project Text
Status Failed
Commit a9e3f2f ℹ️
Started Nov 7, 2022 4:55 PM
Ended Nov 7, 2022 5:01 PM
Duration 06:15 💡
OS Linux Ubuntu - 20.04
Browser Electron 106

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/links.spec.js Failed
1 test link marks > link preview > shows a link preview

Flakiness

sections.spec.js Flakiness
1 Content Sections > Heading anchors > Anchor scrolls into view
mentions.spec.js Flakiness
1 Test mentioning users > Type @ and see the user list

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - very similar to the original PR.
New test is passing and failing cypress test is unrelated. So i think we should give this a go.

@max-nextcloud max-nextcloud merged commit 049f821 into stable25 Nov 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/3269/stable25 branch November 7, 2022 17:10
@blizzz blizzz mentioned this pull request Nov 21, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants