Fix background color of tables #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theme but user uses bright one Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
added
design
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 flaky tests on run #8401 ↗︎
Details:
|
|||||||||||||||||||||
| Test | ||
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliushaertl
approved these changes
Feb 1, 2023
mejo-
approved these changes
Feb 1, 2023
|
Awesome, thanks a lot for looking into this @susnux. |
|
/backport to stable25 |
|
The backport to stable25 failed. Please do this backport manually. |
|
/backport 3700a0f to stable25 |
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
The server css variables are set on the body tag currently, so if we use those variables, e.g. for aliasing them as done here, they need to be evaluated on the same or a child node. This means we can not define aliases on the
:rootelement.🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)