Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix: 403 when session is closed during push #3903

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[stable26] fix: 403 when session is closed during push #3903

merged 1 commit into from
Mar 6, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 6, 2023 •
edited by max-nextcloud
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #3901

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26 milestone Mar 6, 2023
@cypress
Copy link

cypress bot commented Mar 6, 2023 •
edited
Loading

2 flaky tests on run #8913 ↗︎

0 140 0 0 Flakiness 2

Details:

[stable26] fix: 403 when session is closed during push
Project: Text Commit: 5b9c783cb5
Status: Passed Duration: 04:48 💡
Started: Mar 6, 2023 1:43 PM Ended: Mar 6, 2023 1:48 PM
Flakiness  workspace.spec.js • 1 flaky test

View Output Video

Test Artifacts
Workspace > adds a Readme.md Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

juliusknorr
juliusknorr approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress adjustment was not back ported due to a conflict, but backend change is good to go 👍

@max-nextcloud max-nextcloud force-pushed the backport/3901/stable26 branch from 65e5fec to 131f666 Compare March 6, 2023 12:23
@max-nextcloud
Copy link
Collaborator

Rebased on top of #3891 and added back the cypress change

@max-nextcloud
fix: 403 when session is closed during push
5b9c783 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the backport/3901/stable26 branch from 131f666 to 5b9c783 Compare March 6, 2023 13:18
@juliusknorr juliusknorr merged commit cacdb8d into stable26 Mar 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/3901/stable26 branch March 6, 2023 13:57
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@mejo- mejo- Awaiting requested review from mejo-

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
2 participants
@max-nextcloud @juliusknorr