Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UserApiController): Fix warning during test run with PHP 8.2 #4241

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 6, 2023

Fix test failure that only happens on PHP8.2

stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@cypress
Copy link

cypress bot commented Jun 6, 2023

14 failed and 25 flaky tests on run #10001 ↗︎

14 86 1 42 Flakiness 25

Details:

fix(UserApiController): Fix warning during test run with PHP 8.2
Project: Text Commit: 851528c182
Status: Failed Duration: 18:24 💡
Started: Jun 6, 2023 6:27 AM Ended: Jun 6, 2023 6:45 AM
Failed  workspace.spec.js • 2 failed tests

View Output Video

Test Artifacts
Workspace > takes README.md into account Output Screenshots
Workspace > emoji picker Output Screenshots
Failed  sync.spec.js • 1 failed test

View Output Video

Test Artifacts
Sync > saves the actual file and document state Output Screenshots
Failed  shortcuts.spec.js • 1 failed test

View Output Video

Test Artifacts
keyboard shortcuts > strikethrough Output Screenshots
Failed  nodes/Links.spec.js • 1 failed test

View Output Video

Test Artifacts
test link marks > autolink > with protocol but without space Output Screenshots
Failed  attachments.spec.js • 1 failed test

View Output Video

Test Artifacts
Test all attachment insertion methods > Insert an image file from Files Output Screenshots

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

Flakiness  workspace.spec.js • 7 flaky tests

View Output Video

Test Artifacts
Workspace > Hides the workspace when switching to another folder Output Screenshots
Workspace > formats text Output Screenshots
Workspace > creates lists Output Screenshots
Workspace > callouts > toggle callouts Output Screenshots
Workspace > create Readme.md > click Output Screenshots
Workspace > create Readme.md > enter Output Screenshots
Workspace > create Readme.md > spacebar Output Screenshots
Flakiness  shortcuts.spec.js • 2 flaky tests

View Output Video

Test Artifacts
keyboard shortcuts > bold Output Screenshots
keyboard shortcuts > italic Output Screenshots
Flakiness  nodes/Links.spec.js • 2 flaky tests

View Output Video

Test Artifacts
test link marks > link preview > shows a link preview Output Screenshots
test link marks > link preview > does not show a link preview for links within a paragraph Output Screenshots
Flakiness  share.spec.js • 1 flaky test

View Output Video

Test Artifacts
Open test.md in viewer > Shares the file as a public read only link Output Screenshots
Flakiness  sections.spec.js • 1 flaky test

View Output Video

Test Artifacts
Content Sections > Heading anchors > Can change heading level Output Screenshots

The first 5 flaky specs are shown, see all 13 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud
Copy link
Collaborator

Cypress failures cannot be related - but I wonder where the block merges during freezes is coming from...

And i wonder why i could still merge this.

@juliusknorr
Copy link
Member Author

Merge freeze seems like I overseen a change when updating the actions to adapt the server branch when text is using main:

Screenshot 2023-06-06 at 09 04 03

@juliusknorr
Copy link
Member Author

Cypress failure looks a bit like it could be a upstream issue with loading the files app:

https://cloud.cypress.io/projects/hx9gqy/runs/e149dd86-8742-4946-b5fb-7e5277760429/test-results/45605c10-1ad8-4149-84fa-1fc611744854/screenshots

@juliusknorr
Copy link
Member Author

Pushed a fix for the merge block #4243

@juliusknorr juliusknorr merged commit 80bdef9 into main Jun 6, 2023
@juliusknorr juliusknorr deleted the tests/testUsersIndex branch June 6, 2023 09:59
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants