Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Fix missing text on assistant task list #4679

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 14, 2023

Oversight when backporting as @nextcloud/vue on stable27 still uses title instead of name as attributes and slot names

@juliusknorr juliusknorr changed the base branch from main to stable27 August 14, 2023 06:14
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Aug 14, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27.1.0 milestone Aug 14, 2023
@juliusknorr juliusknorr changed the title bugfix/nclistitem title [stable27] Fix missing text on assistant task list Aug 14, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/nclistitem-title branch from 52458d5 to 8742939 Compare August 14, 2023 07:47
@cypress
Copy link

cypress bot commented Aug 14, 2023

6 failed and 1 flaky tests on run #11684 ↗︎

6 139 2 0 Flakiness 1

Details:

[stable27] Fix missing text on assistant task list
Project: Text Commit: 3059bd9699
Status: Failed Duration: 06:29 💡
Started: Aug 14, 2023 8:50 AM Ended: Aug 14, 2023 8:57 AM
Failed  workspace.spec.js • 1 failed test

View Output Video

Test Artifacts
Workspace > relative folder links Output Screenshots
Failed  nodes/Links.spec.js • 3 failed tests

View Output Video

Test Artifacts
... > without text Output Screenshots
... > with selected text Output Screenshots
... > link to directory Output Screenshots
Failed  attachments.spec.js • 2 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > Insert an image file from Files Output Screenshots
Test all attachment insertion methods > test if attachment files are in the attachment folder Output Screenshots
Flakiness  cypress/e2e/files.spec.js • 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle plaintext in a pre tag Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

Failing tests unrelated (see #4680)

@juliusknorr
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 1890663 into stable27 Aug 14, 2023
@juliusknorr juliusknorr deleted the bugfix/nclistitem-title branch August 14, 2023 09:04
@skjnldsv skjnldsv mentioned this pull request Aug 16, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants