[stable28] test(cy): skip test failing due to server issue #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
juliushaertl and
max-nextcloud
juliushaertl
approved these changes
Dec 18, 2023
This was referenced Dec 21, 2023
max-nextcloud
force-pushed
the
backport/5142/stable28
branch
from
178607f
to
1e6841a
Compare
juliushaertl
force-pushed
the
backport/5142/stable28
branch
from
1e6841a
to
fa5c955
Compare
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
juliushaertl
force-pushed
the
backport/5142/stable28
branch
from
fa5c955
to
1cc4ef3
Compare
|
Let me also cherry-pick #5129 into here |
* Use `this.requesttoken` rather than `cy.get(@requesttoken)` to use the same value rather than re-evaluating the query. * After visit `this.requesttoken` will be set. No need to attempt to load the token from the window if it is not. * Use a simple `if` statement instead of `cypress-if`. * This also cleans up the cypress logs significantly. Signed-off-by: Max <max@nextcloud.com>
* call `cy.showHiddenfiles()` before loading the page. * Clear `requesttoken` in `cy.login()`. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Fix the warning in CI. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5142