Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump psalm/phar from 5.19.0 to 5.20.0 #5291

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2024

Bumps psalm/phar from 5.19.0 to 5.20.0.

Commits
  • 459eb19 Updated Psalm phar to commit 3f284e96c9d9be6fe6b15c79416e1d1903dcfef4
  • 6271624 Updated Psalm phar to commit 25fabb8d36b778da106afdfe174382d7d65cff7b
  • 1492660 Updated Psalm phar to commit 09035749afeac86c61a7a41d255523d13e69f595
  • ce2e616 Updated Psalm phar to commit 67c7be3db2afb9efbd4b3464e499a900fcd3b666
  • ce897ab Updated Psalm phar to commit 64868c5c9ff3f025f7e9d2412f5b3b719269361c
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added 3. to review dependencies Pull requests that update a dependency file labels Jan 20, 2024
@dependabot dependabot bot requested review from max-nextcloud and mejo- January 20, 2024 03:47
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot force-pushed the dependabot/composer/psalm/phar-5.20.0 branch from 0d556b1 to 1e1be81 Compare January 20, 2024 05:18
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 20, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@max-nextcloud
Copy link
Collaborator

I tried to fix the warnings in question but turns out it's pretty hard because most of the time we actually mean what we say when using truthy falsy comparisons.
So for example:

if (token) {
  ...
}

Should run the if block if token is not null or empty.

In some cases it's possible to change the function signature to not allow for null and always use a default of ''. I see how this is less ambiguous as there is only one way to encode no token then.

@max-nextcloud max-nextcloud force-pushed the dependabot/composer/psalm/phar-5.20.0 branch 2 times, most recently from b29c5e0 to 2469b90 Compare January 23, 2024 08:56
dependabot bot and others added 2 commits January 27, 2024 10:13
Bumps [psalm/phar](https://github.com/psalm/phar) from 5.19.0 to 5.20.0.
- [Release notes](https://github.com/psalm/phar/releases)
- [Commits](psalm/phar@5.19.0...5.20.0)

---
updated-dependencies:
- dependency-name: psalm/phar
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Max <max@nextcloud.com>
@mejo- mejo- force-pushed the dependabot/composer/psalm/phar-5.20.0 branch from 2469b90 to e551742 Compare January 27, 2024 09:13
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 3, 2024

A newer version of psalm/phar exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@juliusknorr
Copy link
Member

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 4, 2024

Superseded by #5608.

@dependabot dependabot bot closed this Apr 4, 2024
@dependabot dependabot bot deleted the dependabot/composer/psalm/phar-5.20.0 branch April 4, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants