-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup _oc_webroot
stubs where possible
#5378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
test/cleanup-oc-webroot
branch
from
February 11, 2024 13:21
95b9b35
to
71627c0
Compare
juliusknorr
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
just one failure remaining
FAIL src/tests/services/AttachmentResolver.spec.js
Image resolver
✓ is a class with one constructor argument (29 ms)
✓ handles .attachments urls to own fileId via Text API (2 ms)
✓ leaves urls unchanged if they can be loaded directly (1 ms)
✓ handles .attachments urls to different fileId via webdav with text API fallback
✕ handles non-native urls wia webdav (3 ms)
● Image resolver › handles non-native urls wia webdav
expect(received).toBe(expected) // Object.is equality
Expected: "http://localhost/remote.php/dav/files/user-uid/parentDir/path/to/some%20image.png"
Received: "http://localhost//remote.php/dav/files/user-uid/parentDir/path/to/some%20image.png"
88 | const attachment = await resolver.resolve(src)
89 | expect(attachment.isImage).toBe(true)
> 90 | expect(attachment.previewUrl).toBe('http://localhost/remote.php/dav/files/user-uid/parentDir/path/to/some%20image.png')
| ^
91 | })
92 |
93 | })
at Object.toBe (src/tests/services/AttachmentResolver.spec.js:90:33)
We do not need to test functionality internal to `@nextcloud/router`. Signed-off-by: Max <max@nextcloud.com>
* Prevent @nextcloud/router from reading `window.location.pathname` which would include `cypress/_iframe`. * Keep the `window.OC` stub for now for easier backports. Tests pass without it these days. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
juliusknorr
force-pushed
the
test/cleanup-oc-webroot
branch
from
April 4, 2024 07:48
71627c0
to
9dc6291
Compare
/backport to stable29 |
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cy.prepareWindowForSessionApi
cy.sessionUsers()
for users endpoint.its
and.should