Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cypress): Fix selector for new button in files app #5859

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jun 4, 2024

Make it more specific to only select the button in breadcrumbs. In empty folders, there's a similar button in the emptycontent now.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

Make it more specific to only select the button in breadcrumbs. In empty
folders, there's a similar button in the emptycontent now.

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added tests If you write them we ♥ you bug: regression labels Jun 4, 2024
@mejo- mejo- added this to the Nextcloud 30 milestone Jun 4, 2024
@mejo- mejo- requested review from elzody and luka-nextcloud June 4, 2024 08:55
@mejo- mejo- self-assigned this Jun 4, 2024
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@mejo- mejo- merged commit 05b6ad1 into main Jun 4, 2024
59 checks passed
@mejo- mejo- deleted the fix/cypress_files_new branch June 4, 2024 09:54
@mejo-
Copy link
Member Author

mejo- commented Jun 4, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants