Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Lazy load optional dependencies #5886

Merged
merged 2 commits into from
Jun 11, 2024
Merged

perf: Lazy load optional dependencies #5886

merged 2 commits into from
Jun 11, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 11, 2024

📝 Summary

Currently mermaid JS is always imported, but mermaid JS is huge (6MiB code and 3MiB minified).
So instead this imports the mermaid module only if really required the first time.
This will reduce the default loading of the text app by ~1MiB gziped assets.

Also make a custom chunk for the emoji picker to split the nextcloud vue chunk into better loadable ones (2x 700kiB instead of 1500 kiB).

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

susnux added 2 commits June 11, 2024 14:48
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Mermaid JS and its dependency elkjs is a huge depenency (6MiB and 3MiB compressed),
so we only should load it if required.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@juliusknorr juliusknorr merged commit 4988d82 into main Jun 11, 2024
60 checks passed
@juliusknorr juliusknorr deleted the perf/split-chunks branch June 11, 2024 16:46
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants