Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore pushes of update steps for read only sessions #5895

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

juliusknorr
Copy link
Member

My suggestion for now would be to block any update steps for read only sessions according to what is described in the y.js protocol docs.

https://github.com/yjs/y-protocols/blob/master/PROTOCOL.md#handling-read-only-users

Ideally we'd of course also prevent sending those in the frontend code, but for now this seems the most reasonable quick fix.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Jun 13, 2024
@juliusknorr juliusknorr mentioned this pull request Jun 13, 2024
7 tasks
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test - but code looks good.

@juliusknorr juliusknorr merged commit 697b5cd into main Jun 13, 2024
62 checks passed
@juliusknorr juliusknorr deleted the fix/read-only-updates branch June 13, 2024 06:02
@juliusknorr
Copy link
Member Author

/backport to stable29

@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

Copy link

backportbot bot commented Jul 12, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/5895/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 672d3a8f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5895/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants