Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use getFirstNodeById and pass userId for our internal helper to avoid fetching mountpoints #5933

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 20, 2024

If we don't care which node we get by id we can use the optimized/cached getFirstNodeById instead. In addition I noticed we can skip getting mounts for a given file id to determine the user if we pass it upfront to our internal helper to get the file with the highest permission.

… avoid fetching mountpoints

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@juliusknorr juliusknorr merged commit 06f6088 into main Jun 21, 2024
61 of 63 checks passed
@juliusknorr juliusknorr deleted the perf/node-by-id branch June 21, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants